Skip to content

gitignore: fixes for nix output links #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spikespaz wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gitignore: fixes for nix output links #1233

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0aade4
gitignore: ignore result as symlink
spikespaz Jul 23, 2025
f972bf5
gitignore: add nix build output link names
spikespaz Jul 23, 2025
4adf9ee
gitignore: affix known names to repo root
spikespaz Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
# These are backup files generated by rustfmt
**/*.rs.bk

# required by nix
.direnv/
result/
# Nix build output
/result
Copy link
Copy Markdown
Owner

@raphamorim raphamorim Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, so basically to exclude matches anywhere in the repo? (asking to understand the reason)

Copy link
Copy Markdown
Contributor Author

@spikespaz spikespaz Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This / prefix excludes matches only at the root of the repo. There is no trailing / because it's always a symlink, so a directory named result is fine.

You could use result as a bare name, but I don't like to make .gitignore patterns unnecessarily strict.

/result-lib
/result-dev
/result-man

target/
Copy link
Copy Markdown
Owner

@raphamorim raphamorim Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one I rather keep because I use rio in a private fork that I have been working and target is independent there for multi levels

Copy link
Copy Markdown
Contributor Author

@spikespaz spikespaz Oct 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would that be the case? The repository is a workspace, and thus, target should only appear at /.

Having a directory/module named target is perfectly reasonable, perhaps a compromise would be to add !/**/src/**/target/?

Or, I'm a big fan of adding .gitignore in directories which need special handling (for offline work, for example).

/target/
.DS_Store
rls/
.vs
Expand All @@ -17,11 +19,10 @@ release
NOTES
*.log

# for nix users
.direnv/

# compiled terminfo files
misc/72/
/misc/72/

# goreleaser
dist/
/dist/