Add tests for bugs#25
Draft
KostyaEsmukov wants to merge 2 commits intorambler-digital-solutions:masterfrom
Draft
Add tests for bugs#25KostyaEsmukov wants to merge 2 commits intorambler-digital-solutions:masterfrom
KostyaEsmukov wants to merge 2 commits intorambler-digital-solutions:masterfrom
Conversation
KostyaEsmukov
force-pushed
the
add-tests-for-bugs
branch
from
4c326fb to
65bf0f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a couple of commits containing failing tests for the two bugs in Declarative I'm aware of:
doblock strips newlines from the substituted jinja variables, which breaks bash commandsdelta: 1hformat for theTimeDeltaSensoris currently unsupported: it is getting passed as a string rather than a timedelta.This PR shouldn't be merged as is. Instead, the fixes for these bugs should be done on top of the corresponding commits from this PR.