Open
Conversation
- see vitest-dev/vitest#8390 (comment) for path details - I was running node 22 locally hence I didn't see this issues until CI ran
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1587 +/- ##
===========================================
- Coverage 97.60% 97.17% -0.43%
===========================================
Files 56 56
Lines 6004 6226 +222
Branches 679 680 +1
===========================================
+ Hits 5860 6050 +190
- Misses 143 175 +32
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- v5 didn't work nicely with newer react-router, sometimes the single-spa navigation would "finish" before RR (generally when plugins would route to different plugins, but also going forward/back in browser) - and thus the plugin would load into the backup div instead of the proper div
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove connected-react-router and upgrade react-router to v6 and then v7. Had to turn off transitions as they don't work nicely with redux (as it uses
useSyncExternalStore) (see https://reactrouter.com/explanation/react-transitions#opt-out-via-unstable_usetransitionsfalse). Mostly the issue was with the autoLogin middleware changing things around mid routing I think?Otherwise nothing super ground-breaking I think? Had a bit of trouble with how to test certain things with no access to
historyanymore but some research solved all the issues.Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #942