Change maintenance PUT endpoints match what SciGateway expects#170
Merged
louise-davies merged 2 commits intomainfrom Jan 15, 2026
Merged
Change maintenance PUT endpoints match what SciGateway expects#170louise-davies merged 2 commits intomainfrom
louise-davies merged 2 commits intomainfrom
Conversation
…er & the new state is just the whole body
patrick-austin
approved these changes
Jan 15, 2026
Contributor
patrick-austin
left a comment
patrick-austin
left a comment
There was a problem hiding this comment.
Refactor looks good to me, and (for what it's worth) I also prefer doing it this way (auth/tokens/etc. handled with Depends rather than being part of the request body).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OG-api and sg-auth handled the maintenance endpoints slightly differently, and in SciGateway I unified things so everything uses the same maintenance code. I decided the OG way of doing things (passing the token via the Authorization header, and the body is just the new maintenance state) seemed better so I changed SGW to expect that signature. This then aligns scigateway-auth to use the same signature.
Testing Instructions
Add a set up instructions describing how the reviewer should test the code
Agile Board Tracking
Closes #147