Warm cache and handle frozen import maps - #329
Open
etiennebarrie wants to merge 2 commits into
Open
Conversation
A frozen map currently raises when caching resolved paths or the generated JSON. Instead, skip the cache when it is frozen. This allows sharing the import map between Ractors, which requires deep-freezing it, cache included.
Instead of waiting for the first request, warm the cache as best effort during boot for eager-loaded applications. Rather than adding a configuration option, this uses the entry points provided in the preload options of the pins. If an entry point is not listed in any of the preload options, it won't be pre-cached, except the for the default "application" entry point.
Author
|
I have the same failures on main. Something with the CDN I guess… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helps for Ractor support. The Rails application can then deep-freeze (
Ractor.make_shareable) the application map atRails.application.importmap, and it becomes usable from worker Ractors rendering views with the importmap helpers (at the cost of not caching the results anymore).In addition to not raising an exception when the map is frozen, this also pre-warms the cache during boot for eager-loaded apps. This is helpful for any deployment using preforking.
Since we don't know exactly the list of all entry points, and to avoid adding a new configuration option, we use "application" and all the entry points mentioned as preload targets for the pins. That is if you use a string or array of strings in the preload option, they are all considered entry points.
For example in the README example:
This will pre-warm the cache for "application" and "alternate" automatically.
Let me know if you think we should add a configuration option in addition to that, which would allow pre-warming the cache for an entry point that is not explicitly listed but only used in a view/layout.