Adds missing data-bs-target attributes for Bootstrap5 - Resolves issue #134 #135
Open
nickdevore wants to merge 4 commits intorailapex:masterfrom
Open
Adds missing data-bs-target attributes for Bootstrap5 - Resolves issue #134 #135nickdevore wants to merge 4 commits intorailapex:masterfrom
nickdevore wants to merge 4 commits intorailapex:masterfrom
Conversation
…ss is Bootstrap5 for generated BootstrapButtons
…ssFramework is Bootstrap5
nickdevore
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to use the built in javascript ability to have a button show a modal, the attribute needs to be named
data-bs-targetwhere thetargetis the id of the modal you want to popup. This fix uses that attribute when theGriddlyCssisBootstrap5