Ci history gate

[guapisolo]

No description provided.

[gemini-code-assist]

Code Review

This pull request implements a CI metric history and regression gate system, including local NDJSON metric collection, AST-parsed gate specifications, offline and Neon Postgres storage backends with migrations, and integration into the CI test runner harness. The code review feedback focuses on enhancing robustness and resource management, recommending that database connections are reliably closed using try...finally blocks, abstracting the close method in the store interface, and adding defensive exception handling when merging records and initializing the database store to prevent CI runner crashes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

To prevent resource leaks (such as unclosed database connections), it is highly recommended to wrap the execution of run_unittest_files in a try...finally block to ensure that gate_store.close() is always called if gate_store is successfully initialized.

    # Regression-gate wiring: the store exists only when NEON_DATABASE_URL is
    # set (CI), so the gate hook is a no-op locally. is_nightly is the
    # baseline-writing signal (schedule event or stripped nightly label), not
    # args.nightly. Provenance comes from the GitHub env.
    gate_store = build_store_from_env()
    gate_nightly = is_nightly(stripped_labels)
    gate_provenance = gate_provenance_from_env()

    try:
        return run_unittest_files(
            ci_tests,
            timeout_per_file=timeout,
            continue_on_error=args.continue_on_error,
            enable_retry=args.enable_retry,
            max_attempts=args.max_attempts,
            retry_wait_seconds=args.retry_wait_seconds,
            gate_store=gate_store,
            gate_nightly=gate_nightly,
            gate_provenance=gate_provenance,
        )
    finally:
        if gate_store is not None:
            gate_store.close()

References

1. To prevent resource leaks (e.g., counters that are not decremented), use constructs like try...finally or a with statement to ensure cleanup logic is always executed, even in the case of exceptions or early returns.

[gemini-code-assist]

To ensure robustness and defensive programming, _merge_attempt_records should catch potential exceptions (such as json.JSONDecodeError from corrupted/partially written files, or file access/permission errors) so that a malformed process record does not crash the entire CI runner process.

def _merge_attempt_records(attempt_dir: str, merged_path: str) -> None:
    """Merge every per-process NDJSON file under 'attempt_dir' into one record.

    Each per-process file holds lines of '{"metric": key, "series": [[step, value], ...]}'.
    The same metric key may appear across processes (driver + actors); concatenate
    their series and sort by step so the merged per-run record is coherent.
    """
    if not os.path.isdir(attempt_dir):
        return
    try:
        merged: dict[str, list[list]] = {}
        for fname in sorted(os.listdir(attempt_dir)):
            if not fname.endswith(".ndjson"):
                continue
            with open(os.path.join(attempt_dir, fname), encoding="utf-8") as f:
                for line in f:
                    line = line.strip()
                    if not line:
                        continue
                    try:
                        rec = json.loads(line)
                        merged.setdefault(rec["metric"], []).extend(rec["series"])
                    except (json.JSONDecodeError, KeyError, TypeError) as e:
                        logger.warning(f"Malformed line in {fname}: {e}")
                        continue

        for points in merged.values():
            points.sort(key=lambda p: (p[0] is None, p[0]))

        with open(merged_path, "w", encoding="utf-8") as f:
            for metric, points in merged.items():
                f.write(json.dumps({"metric": metric, "series": points}) + "\n")
    except Exception as e:
        logger.warning(f"Failed to merge attempt records in {attempt_dir}: {e}")

[gemini-code-assist]

To prevent transient database connection failures or misconfigured environment variables from crashing the entire CI run on startup, build_store_from_env should catch any exceptions raised during the instantiation of NeonMetricHistoryStore and return None with a warning.

def build_store_from_env():
    """Return the metric-history store for this environment, or None.

    A hosted store is used only when 'NEON_DATABASE_URL' is set (CI with the
    secret inherited). Locally / in dev the var is unset and this returns None,
    which disables the gate hook entirely -- no store, no evaluation, no writes.
    """
    if os.environ.get(NEON_DATABASE_URL_ENV):
        try:
            return NeonMetricHistoryStore()
        except Exception as e:
            logger.warning(f"[CI Gate] Failed to initialize NeonMetricHistoryStore: {e}")
            return None
    return None

[gemini-code-assist]

It is good practice to define a close method in the abstract base class MetricHistoryStore so that callers can uniformly close any store implementation to release underlying resources.

    @abc.abstractmethod
    def mark_untrusted(
        self,
        *,
        run_id: str | None = None,
        github_run_id: int | None = None,
        commit_sha: str | None = None,
    ) -> int:
        """Revoke trust on the runs matching exactly one of the given keys.

        Returns the number of run rows whose 'trusted' flag changed from true
        to false. Already-untrusted matches do not count. Revocation takes
        effect immediately for subsequent 'recent_trusted_values' calls; no
        rebaseline step is required.

        Exactly one of 'run_id' / 'github_run_id' / 'commit_sha' must be
        provided.
        """

    def close(self) -> None:
        """Close the store and release any underlying resources."""
        pass

[mintlify]

Preview deployment for your docs. Learn more about Mintlify Previews.

Project	Status	Preview	Updated (UTC)
radixark	🟢 Ready	View Preview	Jun 29, 2026, 7:29 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.