Updates for auto spectrum simulations#89
Open
sjforeman wants to merge 39 commits into
Open
Conversation
style: blacken
… constant redshift
…iser term This commit also modifies several containers to track whether phi or d^2phi is being stored. This is automatically detected in simulation tasks and used to determine how to simulate the Kaiser term.
…nto arbitrary bins
This scheme allows for Finger-of-God damping to be incorporated in the MAPS calculator prior to channel-integration, which addresses issues that have been identified in the map-level approach.
…arPowerSpectrum): add frequency padding for FoG convolution
… channel profile for angular power spectrum
…ng frequency channel profiles
This refactors CalculateMultiFrequencyAngularPowerSpectrum into a base class and subclasses that compute spectra for a single tracer, or for two correlated tracers.
This commit also renames GenerateInitialLSSFromCl to GenerateSingleTracerInitialLSSFromCl, for consistency with the new GenerateDoubleTracerInitialLSSFromCl task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes updates that were used for the auto spectrum interpretation paper and associated detection paper updates:
cora.core.skysim.clarray()constant_redshiftoption in a few routines incora.signal.corrandcora.signal.corr21cmcora.signal.corrfunc.corr_to_clarray()cora.signal.lss.CalculatePFBChannelProfiletaskcora.signal.lsscora.signal.lss.util.Pk2d_to_Clclass. The design and location of this are a bit strange, and should eventually be refactored, but the current version works.The
sf/alt-fogbranch was actually used to generate the simulations for the papers, but is based on the pre-refactor versions ofradiocosmologypackages. This branch has been updated to work with the new packages, and I've run a few spot checks to verify that the outputs are consistent with those of the older branch.