Conversation
Summary of ChangesHello @AymenFJA, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the project's metadata to reflect a new release version and a change in the project's official hosting and contact URLs. These changes ensure that the package information is current and points to the correct resources. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the package version to 0.1.2 and changes the project URLs to reflect a move to a new GitHub organization. The changes are consistent across the project. I've added one suggestion to improve version management by using a single source of truth, which will make future releases less error-prone.
| from .logger import enable_logging | ||
|
|
||
| __version__ = "0.1.1" | ||
| __version__ = "0.1.2" |
There was a problem hiding this comment.
To improve maintainability and avoid potential mismatches, it's recommended to have a single source of truth for your package's version. Since the version is defined in pyproject.toml, you can read it dynamically here instead of hardcoding it. This prevents scenarios where the version might be updated in one file but not the other during a release.
You can achieve this using importlib.metadata (available in Python 3.8+, and your project requires >=3.9):
# Add this import at the top of the file
from importlib import metadata
# ...
# Replace the hardcoded version with this
try:
__version__ = metadata.version("rhapsody-py")
except metadata.PackageNotFoundError:
# The package is not installed, which can happen in development.
__version__ = "0.1.2" # Fallback versionThis change will make your version management more robust.
No description provided.