Open
Conversation
910318f to
84e8464
Compare
gadomski
approved these changes
Dec 1, 2025
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '16.14' |
There was a problem hiding this comment.
Any reason this is a different node version than the other actions? If we wanted a single source of truth, we could use a node-version-file: https://github.com/actions/setup-node?tab=readme-ov-file#usage
There was a problem hiding this comment.
I usually use https://github.com/actions/deploy-pages, which would take care of a lot of this for us. It's ok to keep doing this publish.js workflow if we want to reduce the number of changes in this PR, too.
jsignell
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Closes #457, #456, #455, #454
Proposed Changes:
Not sure how to fully disable circleci yet. Maybe this gets only picked up after merge?
PR Checklist:
stac-specdirectory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)