fix: use proper path separator on Windows#358
Open
DinoChiesa wants to merge 2 commits intoradian-software:mainfrom
Open
fix: use proper path separator on Windows#358DinoChiesa wants to merge 2 commits intoradian-software:mainfrom
DinoChiesa wants to merge 2 commits intoradian-software:mainfrom
Conversation
Author
|
regarding the 79-char limit, ironically, I don't have an elisp formatter that re-formats the 79 characters limit. The default formatter I have is |
Member
|
I just do it manually, I'm not aware of any re-flowing Elisp formatters. We should add a changelog entry though, if one is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the use of ":" as a separator for path elements. This is inappropriate for Windows.
There's a variable we can use instead:
path-separator.I don't know exactly what breaks when the wrong separator is used. I do know that it's common for Windows paths to include ":" because that is the separator between the drive letter and the drive-local path.