Top bar improvements

[Rylern]

Address #10 by:

• Updating the combobox to reflect the currently-open page.
• Putting the top bar on one horizontal line.

[petebankhead]

I like the saved space (current screenshot below, for 'before' see #10 ) & especially how the selected jar updates to match the page.

---

• Should the search bar be on the right, not the left? I was thinking left, to make it the most prominent input control.
• The min width seems quite larger - could this be reduced?
  • I think an HBox is being used for the title bar currently; did you compare this with a ToolBar? A ToolBar should make it possible to shrink further and add extra buttons to access options that don't fit, but I'm not certain if this would be a good or a bad thing.

Pinging @finglis and @alanocallaghan for their thoughts.

[Rylern]

Here is how it looks with the search on the left:

And on the right:

I agree with Alan and I prefer the search on the right, as I see the Javadoc viewer a bit like a web browser, the combobox like the URL, and yes Firefox got me used to having the search on the right.

I switched the Hbox to a Toolbar but the behaviour is the same, what should change?

[petebankhead]

I agree with Alan and I prefer the search on the right, as I see the Javadoc viewer a bit like a web browser, the combobox like the URL, and yes Firefox got me used to having the search on the right.

I also see it as a web browser, which is why I prefer it on the left + center... the big inviting space to type in. Generally I use the URL bar to search.

But in that case, the search bar should be the one that fills as much extra width as is available - to make it the most prominent control. It also doesn't need 'Search' as a label - since URL bars don't say this - and instead the prompt text of the text field could be used.

My thinking is less about right and left, but more about nudging the user into paying attention to the control that they are most likely to want to use... and I think searching will be more common than selecting a jar.

But if the combo box needs to be as wide as it currently is, then I agree that the search bar looks better on the right... because placing it on the left, but narrow, creates a confusing message about which one the user should focus on.

So from your two screenshots, I do prefer the second one. I'm ok if the consensus is that we stick with it.

I switched the Hbox to a Toolbar but the behaviour is the same, what should change?

If you can decrease the width of the window, I'd expect the toolbar to behave differently when the components don't all fit.

[Rylern]

Something like this?

[Rylern]

The viewer in the last screenshot was implemented in the last commit.

[petebankhead]

Thanks, looks good, let's merge!