Skip to content

Adding dissagg mode support to Qwen3Moe#682

Merged
quic-hemagnih merged 26 commits intoquic:mainfrom
qcdipankar:qwen3moe_dissagg_mode
Mar 10, 2026
Merged

Adding dissagg mode support to Qwen3Moe#682
quic-hemagnih merged 26 commits intoquic:mainfrom
qcdipankar:qwen3moe_dissagg_mode

Conversation

@qcdipankar
Copy link
Contributor

@qcdipankar qcdipankar commented Dec 22, 2025

#672

Adding disagg support to Qwen3Moe

Config used

PL =128

CL=128*3

image

@qcdipankar qcdipankar self-assigned this Dec 22, 2025
@qcdipankar qcdipankar marked this pull request as draft December 22, 2025 11:44
@qcdipankar qcdipankar force-pushed the qwen3moe_dissagg_mode branch from ea01462 to e5c76ca Compare December 22, 2025 17:54
@qcdipankar qcdipankar marked this pull request as ready for review December 22, 2025 19:26
@qcdipankar qcdipankar force-pushed the qwen3moe_dissagg_mode branch from 5e0dcd3 to f24dc83 Compare December 24, 2025 06:40
@qcdipankar qcdipankar marked this pull request as draft December 24, 2025 13:34
@qcdipankar qcdipankar assigned qcdipankar and unassigned qcdipankar Dec 25, 2025
@qcdipankar qcdipankar marked this pull request as ready for review January 5, 2026 17:43
@quic-hemagnih
Copy link
Contributor

@qcdipankar @ochougul Is there anything pending on this PR? @qcdipankar Can you resolve the lint issues and run the CI post that I will merge it.

Code wise looks good to me.

Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
@qcdipankar qcdipankar force-pushed the qwen3moe_dissagg_mode branch from 11f9892 to 7030410 Compare March 9, 2026 11:22
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Comment on lines +41 to +43
# Following command errors out by default, the user is supposed to run the printed command and provide the generated qpc path as prefill_qpc_path commenting out lines 55-68

# prefill_qpc_path = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qcdipankar Can you please take care of this in upcoming PR.

@quic-hemagnih quic-hemagnih merged commit 3d0d663 into quic:main Mar 10, 2026
4 checks passed
qcdipankar added a commit that referenced this pull request Mar 10, 2026
**Adding disagg support to Qwen3Moe**

> Config used

PL =128

CL=128*3

<img width="726" height="1077" alt="image"
src="https://github.com/user-attachments/assets/7b9afa00-8505-4df5-9a91-68b55e89b416"
/>

---------

Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
quic-dhirajku pushed a commit to asmigosw/efficient-transformers that referenced this pull request Mar 13, 2026
quic#672

**Adding disagg support to Qwen3Moe**

> Config used

PL =128

CL=128*3

<img width="726" height="1077" alt="image"
src="https://github.com/user-attachments/assets/7b9afa00-8505-4df5-9a91-68b55e89b416"
/>

---------

Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
Signed-off-by: Dhiraj Kumar Sah <dhirajku@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants