fix(postgres): remove hardcoded public. schema prefix from GetEnrichment query#1778
Merged
github-actions[bot] merged 1 commit intoquay:mainfrom Mar 16, 2026
Merged
Conversation
Remove explicit public. schema qualification from the GetEnrichment query. This makes the method consistent with all other queries in the package, which use unqualified table names resolved via PostgreSQL's search_path setting. Signed-off-by: Dennis Andersen <dennis.andersen@fortnox.se>
hdonnay
approved these changes
Mar 16, 2026
Member
hdonnay
left a comment
hdonnay
left a comment
There was a problem hiding this comment.
LGTM
Thanks! This is definitely the intent of what should be happening.
Member
|
/fast-forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GetEnrichment query in datastore/postgres/enrichment.go explicitly references public.enrichment, public.uo_enrich, and public.latest_update_operations, bypassing PostgreSQL's search_path resolution.
All other queries in the same file use unqualified table names. This inconsistency causes SQLSTATE 42P01 errors when tables reside in a non-default schema (e.g. when search_path is configured at the database or role level).
This change removes the public. prefix from the three table references, making GetEnrichment consistent with the rest of the codebase.
Fixes issue #1777