Skip to content

Revert: all: account for language package overwrites#1562

Merged
github-actions[bot] merged 1 commit intoquay:mainfrom
crozzy:revert-ff0aeab9703937d4b2a76b23676e0ebcd77226b0
Jun 4, 2025
Merged

Revert: all: account for language package overwrites#1562
github-actions[bot] merged 1 commit intoquay:mainfrom
crozzy:revert-ff0aeab9703937d4b2a76b23676e0ebcd77226b0

Conversation

@crozzy
Copy link
Copy Markdown
Contributor

@crozzy crozzy commented Jun 4, 2025

This reverts commit ff0aeab.

@crozzy crozzy requested a review from a team as a code owner June 4, 2025 20:50
@crozzy crozzy requested review from hdonnay and removed request for a team June 4, 2025 20:50
This reverts commit ff0aeab.

Signed-off-by: crozzy <joseph.crosland@gmail.com>
@crozzy crozzy force-pushed the revert-ff0aeab9703937d4b2a76b23676e0ebcd77226b0 branch from 5031d02 to 6624a82 Compare June 4, 2025 20:52
@crozzy
Copy link
Copy Markdown
Contributor Author

crozzy commented Jun 4, 2025

I think as there have been no claircore releases in-between this being merged and this being reverted I don't think futzing around with the scanner versions is worth it.

@crozzy crozzy requested a review from RTann June 4, 2025 21:11
@RTann
Copy link
Copy Markdown
Contributor

RTann commented Jun 4, 2025

Reverts #1275 as there was an issue where a PackageDB references multiple packages

@crozzy
Copy link
Copy Markdown
Contributor Author

crozzy commented Jun 4, 2025

For future people: The fact that the PackageDB is not unique across packages (particularly in the go and java ecosystems) meant that only one package would show up in index reports for packages that came from the same binary (as go deps for example).

@crozzy
Copy link
Copy Markdown
Contributor Author

crozzy commented Jun 4, 2025

/fast-forward

@github-actions github-actions bot merged commit 6624a82 into quay:main Jun 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants