Add MultiCoalescer#1557
Closed
Conversation
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED Signed-off-by: RTann <rtannenb@redhat.com>
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED Signed-off-by: RTann <rtannenb@redhat.com>
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED Signed-off-by: RTann <rtannenb@redhat.com>
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED Signed-off-by: RTann <rtannenb@redhat.com>
Signed-off-by: RTann <rtannenb@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Contributor
|
I think this moot now and we should investigate another solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
(*language.coalesce).Coalescefunction does not work well when there are multiple packages under the same Package DB. This is common for Go and Java packages, so this solution is insufficient for those two ecosystems.This change brings back the old, language-specific Coalesce method but puts it in the common
languagepackage, as all of the old coalescers for languages were essentially the same (see the change which added thelanguagepackage here. This will just be used by Go and Java at this time.Also, instead of mapping from package db -> package,
(*language.coalesce).Coalescenow maps from filepath -> package. That's because theFilepathfield is a more accurate representation of where the package is located thanPackageDB. For example, Python packages have aPackageDBset to the directory in which the Egg or Wheel is located instead of the location of Egg/Wheel