rpm: add function to determine if paths are RPM#1473
Merged
github-actions[bot] merged 2 commits intoquay:mainfrom Apr 7, 2025
Merged
rpm: add function to determine if paths are RPM#1473github-actions[bot] merged 2 commits intoquay:mainfrom
github-actions[bot] merged 2 commits intoquay:mainfrom
Conversation
crozzy
force-pushed
the
rpm-filechecker
branch
from
352f59f to
adba6a6
Compare
crozzy
commented
Jan 27, 2025
crozzy
force-pushed
the
rpm-filechecker
branch
3 times, most recently
from
244e040 to
364e886
Compare
Contributor
Author
|
supersedes #1320 |
RTann
reviewed
Jan 29, 2025
crozzy
force-pushed
the
rpm-filechecker
branch
from
364e886 to
ff26c54
Compare
crozzy
force-pushed
the
rpm-filechecker
branch
from
ff26c54 to
e4b2fdf
Compare
RTann
reviewed
Feb 3, 2025
crozzy
force-pushed
the
rpm-filechecker
branch
2 times, most recently
from
48703f5 to
25156b2
Compare
RTann
reviewed
Feb 4, 2025
RTann
reviewed
Feb 5, 2025
BradLugo
reviewed
Feb 5, 2025
crozzy
force-pushed
the
rpm-filechecker
branch
3 times, most recently
from
83b1075 to
0eacf93
Compare
RTann
reviewed
Feb 7, 2025
RTann
reviewed
Feb 7, 2025
crozzy
force-pushed
the
rpm-filechecker
branch
from
0eacf93 to
8c8c5d7
Compare
crozzy
force-pushed
the
rpm-filechecker
branch
from
8c8c5d7 to
5331a16
Compare
crozzy
force-pushed
the
rpm-filechecker
branch
2 times, most recently
from
d75a4cf to
2b27c67
Compare
BradLugo
previously approved these changes
Mar 27, 2025
Contributor
BradLugo
left a comment
BradLugo
left a comment
There was a problem hiding this comment.
I have just one hang-up, but it's non-blocking. I think we should get more reviewers' approval before merging.
BradLugo
previously approved these changes
Mar 27, 2025
Contributor
BradLugo
left a comment
BradLugo
left a comment
There was a problem hiding this comment.
LGTM! I still think we should get more reviewers' approval before merging 🙂
RTann
previously approved these changes
Apr 4, 2025
| return nil, fmt.Errorf("rpm: error reading native db: %w", err) | ||
| return nil, err | ||
| } | ||
| pkgs = append(pkgs, ps...) |
Contributor
There was a problem hiding this comment.
I was afraid of blindly doing this for the return nil, nil case in getDBObjects, but since that returns a slice, it should be ok, and this should truly be a no-op. Another idea may be to return some InvalidNativeDB error and then opt to ignore it here. Either works
crozzy
force-pushed
the
rpm-filechecker
branch
2 times, most recently
from
08e184f to
9dfa98b
Compare
Allow language indexers to check if the filepaths they are interested in have been installed via RPM. Signed-off-by: crozzy <joseph.crosland@gmail.com>
Check whether interesting paths were installed by RPM during language level indexing. Signed-off-by: crozzy <joseph.crosland@gmail.com>
Contributor
Author
|
/fast-forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow language indexers to check if the filepaths they are interested in have been installed via RPM.
The first iteration of this came in the form of #1320 which would save all the RPM files with an rpm.Filescanner and compare them to the language Package's file during the
Resolvestep however it required saving lots of filepath data to the database in order to make the determination.This changeset allows dynamic checking of RPM files during language indexing (akin to how we use the INSTALLER file currently) without the extra storage requirements (that could be huge with a large, diverse corpus of images). Also, as the results are cached for the request duration we don't need to trade reduced storage for increased memory/io.