fix: add timeout to awsenv.Ensure and support value type input in EncryptStruct/DecryptStruct#8
Merged
dorothyyzh merged 5 commits intomainfrom Mar 17, 2026
Merged
fix: add timeout to awsenv.Ensure and support value type input in EncryptStruct/DecryptStruct#8dorothyyzh merged 5 commits intomainfrom
dorothyyzh merged 5 commits intomainfrom
Conversation
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| func runOidc2aws(alias string) (string, error) { | ||
| cmd := exec.Command("oidc2aws", "-login", "-alias", alias, "--env") | ||
| func runOidc2aws(ctx context.Context, alias string) (string, error) { | ||
| cmd := exec.CommandContext(ctx, "oidc2aws", "-login", "-alias", alias, "--env") |
There was a problem hiding this comment.
Possible command injection via shell script - medium severity
Your code spawns a subprocess via a shell script. User input could be abused to inject extra commands.
Show fix
Remediation: This issue can be mitigated or ignored if you verified or sanitized the user input used in the shell command.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
dorothyyzh
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
awsenv: add configurable timeout to Ensure
Optionpattern with WithTimeout (default 10s)exec.CommandContext,TryLockContext, STS calls)manager: support value type (non-pointer) input in EncryptStruct/DecryptStruct
EncryptStructandDecryptStructnow accept both value types and pointer typesvalue_type_inputtest case