Usage examples now reference rachis not qiime2#390
Closed
Oddant1 wants to merge 2 commits intoqiime2:devfrom
Closed
Usage examples now reference rachis not qiime2#390Oddant1 wants to merge 2 commits intoqiime2:devfrom
Oddant1 wants to merge 2 commits intoqiime2:devfrom
Conversation
Member
|
@Oddant1 - do you know why the build failed? |
Member
|
I'm a little confused how there is a diff here, because #389 happened and is in dev. |
Member
|
Hey @Oddant1 you were just behind, I pushed a merge commit and the diff is now empty. CI is still upset, but @lizgehret is looking into that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage examples now import from rachis not from qiime2 (at least I'm seeing failures due to this locally). This updates the checks in the cli to check for rachis not qiime2.
Is this what we want? I'm assuming we want to use the new name.