Conversation
| click and the ending right click are necessary in this mode. | ||
| * The |digitizeShape| :sup:`Digitize Shape`: triggers tools on the | ||
| :ref:`Shape Digitizing Toolbar <shape_edit>` to draw a polygon of a regular shape. | ||
| * The |digitizeWithNURBS| :sup:`Digitize with NURBS Curve`: creates smooth curves using |
There was a problem hiding this comment.
Thanks @hefniraera !
Are you planning to include Bézier curves in this PR as well, or do you want to create a separate one for that?
There was a problem hiding this comment.
Im probably going to include it in this PR @lbartoletti
There was a problem hiding this comment.
I was wondering if you're going to open a PR related to Bezier curve as you mentioned here. Could you also please clarify what the 'Weight' represents? Thank you.
There was a problem hiding this comment.
If you want, I can write a short paragraph about Bézier right here.
As for the weight, it’s important to know that there’s a map tool shortcut associated with the W key + mouse wheel (Ctrl modifier: fine adjustment / Shift modifier: coarse adjustment ) that lets you move closer to or farther from a control point. This determines the weight. If a point has a higher weight, the curve will be pulled more toward that point than if it has a lower weight.
There was a problem hiding this comment.
If you want, I can write a short paragraph about Bézier right here.
Yes, please.
As for the weight, it’s important to know that there’s a map tool shortcut associated with the W key + mouse wheel (Ctrl modifier: fine adjustment / Shift modifier: coarse adjustment ) that lets you move closer to or farther from a control point. This determines the weight. If a point has a higher weight, the curve will be pulled more toward that point than if it has a lower weight.
That helps. Let me try on my side. Thanks
There was a problem hiding this comment.
@lbartoletti Speaking about weight, I'm not sure how broadly it applies across different tools. After testing it in QGIS, it applies to nurbs curve only, at least for now. I'm also quite unfamiliar with bezier curve. After digging into it a bit, I'm wondering what kind of bezier does QGIS implement? From what I've read, there are different kinds, including rational bezier which supports weight (not like bezier in QGIS). Given that, do you think the name "Digitize with Bézier Curve" is too generic?
cc @DelazJ
There was a problem hiding this comment.
After testing it in QGIS, it applies to nurbs curve only, at least for now.
Yes, it is.
Given that, do you think the name "Digitize with Bézier Curve" is too generic?
No, I think it's ok.
I can propose something like (AI has been used to help me):
- The |digitizeWithNURBS| :sup:Digitize with Bézier Curve: creates smooth curves
by placing anchor points with control handles, similar to the pen tool in vector
graphics editors. Each anchor has two handles that define how the curve enters and
leaves that point.
And if we want to describe the actions:
- Click and drag on empty space to add a new anchor point. The drag direction
defines symmetric handles: the right handle follows the mouse while the left
handle mirrors it on the opposite side.
- Click and drag on an existing anchor to move it. Both handles move along with
the anchor, preserving the curve shape.
- :kbd:Alt + click and drag on an existing anchor to redefine its handles
symmetrically, without moving the anchor itself.
- Click and drag on a handle to move it independently, adjusting only one side
of the curve at that anchor.
- Right-click to finish the curve.
There was a problem hiding this comment.
And if we want to describe the actions:
IMHO this is a must-do. We should explain how technically people are expected to use these techniques/tools and the parameters they have to deal with. But I wouldn't put the details here because this simply introduces the various drawing techniques. Should probably have a dedicated sub-section in "adding features" and/or "vertex tool" features?
There was a problem hiding this comment.
- Click and drag on an existing anchor to move it. Both handles move along with the anchor, preserving the curve shape.
This action does not work on my end (windows). I can move each handle but not the anchor. Since you said it's AI generated, could you please confirm if this behavior is correct? @lbartoletti
DelazJ
left a comment
There was a problem hiding this comment.
@hefniraera TBH I am not familiar with this kind of drawing tools and just made a quick test right now to comment (and won't have time to do more soon).
Some limitations that need to be mentioned: better store features in a nurbscurve layer (any other fully supporting layer type, Loïc?) if you don't want segmented lines and be able to properly edit with vertex tool.
| The selected technique remains while switching among the digitizing tools. | ||
| You can combine any of the first three methods while drawing the same geometry. |
There was a problem hiding this comment.
These statements seem to have gotten some changes. Can you check and adjust?
And for completeness, you would need to walk through the existing tools and check whether their description complies with these new techniques or not.
| click and the ending right click are necessary in this mode. | ||
| * The |digitizeShape| :sup:`Digitize Shape`: triggers tools on the | ||
| :ref:`Shape Digitizing Toolbar <shape_edit>` to draw a polygon of a regular shape. | ||
| * The |digitizeWithNURBS| :sup:`Digitize with NURBS Curve`: creates smooth curves using |
There was a problem hiding this comment.
And if we want to describe the actions:
IMHO this is a must-do. We should explain how technically people are expected to use these techniques/tools and the parameters they have to deal with. But I wouldn't put the details here because this simply introduces the various drawing techniques. Should probably have a dedicated sub-section in "adding features" and/or "vertex tool" features?
|
@lbartoletti some issues I think I found when testing and no time to properly report upstream:
|
mm, seems ok to me, activating "Enable self-snapping"
It's normal
It's also normal
Yes, you couldn't add a part to a nurbs. I tried but haven't had the issues you encounter. |

fixes #10692 fixes #10711
Goal:
Ticket(s): #