-
Notifications
You must be signed in to change notification settings - Fork 16
fix: run version compatibility check with the resolved API key credentials #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Anush008
merged 4 commits into
qdrant:master
from
jamesm6162:fix/compatibility-check-credentials
Jun 23, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b27b318
fix: authenticate version compatibility check with resolved credentials
jamesm6162 8f91d01
ci: Use actions/checkout v5 to resolve dev-vince/actions-publish-java…
Anush008 6ec699c
Apply suggestions from code review
Anush008 9b4a598
chore: Bump version to v1.18.3
Anush008 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
src/test/java/io/qdrant/client/QdrantGrpcClientCompatibilityTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| package io.qdrant.client; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertInstanceOf; | ||
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.mockStatic; | ||
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import io.grpc.CallCredentials; | ||
| import io.grpc.ManagedChannel; | ||
| import io.qdrant.client.grpc.QdrantGrpc; | ||
| import io.qdrant.client.grpc.QdrantOuterClass; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.ArgumentCaptor; | ||
| import org.mockito.MockedStatic; | ||
|
|
||
| /** | ||
| * Unit tests for the version compatibility check performed by {@link | ||
| * QdrantGrpcClient.Builder#build()}. | ||
| */ | ||
| class QdrantGrpcClientCompatibilityTest { | ||
|
|
||
| @Test | ||
| void compatibility_check_uses_api_key_credentials_from_with_api_key() { | ||
| ManagedChannel channel = mock(ManagedChannel.class); | ||
| QdrantGrpc.QdrantBlockingStub stub = mock(QdrantGrpc.QdrantBlockingStub.class); | ||
| QdrantOuterClass.HealthCheckReply reply = | ||
| QdrantOuterClass.HealthCheckReply.newBuilder() | ||
| .setTitle("qdrant") | ||
| .setVersion("1.0.0") | ||
| .build(); | ||
|
|
||
| try (MockedStatic<QdrantGrpc> grpc = mockStatic(QdrantGrpc.class)) { | ||
| grpc.when(() -> QdrantGrpc.newBlockingStub(any())).thenReturn(stub); | ||
| when(stub.withCallCredentials(any())).thenReturn(stub); | ||
| when(stub.healthCheck(any())).thenReturn(reply); | ||
|
|
||
| QdrantGrpcClient client = | ||
| QdrantGrpcClient.newBuilder(channel, false, true).withApiKey("my-api-key").build(); | ||
| client.close(); | ||
|
|
||
| ArgumentCaptor<CallCredentials> credentialsCaptor = | ||
| ArgumentCaptor.forClass(CallCredentials.class); | ||
| verify(stub).withCallCredentials(credentialsCaptor.capture()); | ||
|
|
||
| CallCredentials usedCredentials = credentialsCaptor.getValue(); | ||
| assertNotNull( | ||
| usedCredentials, | ||
| "Version compatibility check must run with the API key credentials, not null"); | ||
| assertInstanceOf(MetadataCredentials.class, usedCredentials); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.