fix(calc): correct FREQUENCY output and simplify implementation#2286
Open
shcabin wants to merge 2 commits intoqax-os:masterfrom
Open
fix(calc): correct FREQUENCY output and simplify implementation#2286shcabin wants to merge 2 commits intoqax-os:masterfrom
shcabin wants to merge 2 commits intoqax-os:masterfrom
Conversation
added 2 commits
April 4, 2026 23:35
- Removed the incorrect `c[1], c[2] = c[2], c[1]` swapping logic so results match Excel - Use row-major traversal and ensure output order - Replaced the redundant allocation and assignment loops with a single `make` allocation for the output matrix. - Added comprehensive test cases in `calc_test.go` using `INDEX` and array constants to verify the correct distribution of counts across all buckets, ensuring the removal of the swap logic maintains accurate behavior.
shcabin
force-pushed
the
fix/FREQUENCY_swap
branch
from
9aac816 to
31a2315
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2286 +/- ##
==========================================
- Coverage 99.60% 99.60% -0.01%
==========================================
Files 32 32
Lines 26715 26706 -9
==========================================
- Hits 26609 26600 -9
Misses 55 55
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Fix the FREQUEncy formula
c[1], c[2] = c[2], c[1]swapping logic so results match Excelmakeallocation for the output matrix.calc_test.gousingINDEXand array constants to verify the correct distribution of counts across all buckets, ensuring the removal of the swap logic maintains accurate behavior.Description
Related Issue
Motivation and Context
How Has This Been Tested
Types of changes
Checklist