Unlock mutex before returning error

[Journeyman150]

PR Details

Fixed 2 potential vulnerabilities (deadlock) related to f.mu.Unlock() not being called before returning an error.

Description

Added calls to f.mu.Unlock() before returning an error.
Affected methods:

• styles.go:1661: GetStyle(idx int)
• styles.go:1766: GetConditionalStyle(idx int)

Related Issue

Motivation and Context

How Has This Been Tested

Tested by running all existing tests

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.60%. Comparing base (48a958f) to head (f3d39c8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2281   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          32       32           
  Lines       26697    26699    +2     
=======================================
+ Hits        26591    26593    +2     
  Misses         55       55           
  Partials       51       51           

Flag	Coverage Δ
unittests	99.60% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[xuri]

Good catch! Thanks for your contribution.