feat: Enhance chart title features with overlay, fill, and layout options#2278
feat: Enhance chart title features with overlay, fill, and layout options#2278xuri merged 6 commits intoqax-os:masterfrom
Conversation
…y, add TitleOverlay, TitleFill, TitleBorder and TitleLayout fields Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
xuri
left a comment
There was a problem hiding this comment.
Thanks for your PR. I've left some comments.
- Add exported `ChartTitle` data type - Change Title field data type of Chart from []RichTextRun to ChartTitle - Update README and unit tests - Update chart cell for tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2278 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 32 32
Lines 26654 26697 +43
=======================================
+ Hits 26548 26591 +43
Misses 55 55
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Renamed data type ChartDashType to LineDashType - Renamed data type ChartLineType to LineType - Renamed data type ChartLine to LineOptions - Change Line field data type of Shape from ShapeLine to LineOptions
|
Great |
xuri
left a comment
There was a problem hiding this comment.
The screenshot below shows the line formatting settings panels for both shape outlines and chart title lines. As you can see, properties such as line type and width are consistent across both, which allows us to reuse the same data structure for line formatting.
Based on your branch, I have introduced some breaking changes, including the adoption of LintOptions for both shapes and charts.
Description
Add support for chart title customization: overlay mode, background fill, border style, and manual layout position. Introduces four new fields to the Chart struct while keeping Title []RichTextRun unchanged for full backward compatibility.
New fields added to Chart:
Internal changes:
Motivation and Context
Previously there was no way to control the chart title's visual style or exact position. Users who needed to overlay the title on the plot area, apply a background color, add a border, or pin the title to a specific region of the chart had no API to do so.
How Has This Been Tested
Unit tests added in chart_test.go covering:
Types of changes
Checklist