#1402 Get CountRows from sheet

[ivolkoff]

PR Details

Get CountRows from sheet

Description

Get CountRows from sheet

Related Issue

#1402

Motivation and Context

Current solutions are slow. My solution is fast.

file 1М rows
| - | - | - |
|---|---|---|
| BenchmarkFile_GetRows_Old-8 | 1 | 5797898958 ns/op |
| BenchmarkFile_GetRows_New-8 | 3 | 411330472 ns/op |

How Has This Been Tested

Run test TestFile_CountRows

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.60%. Comparing base (0aec9b7) to head (0205c0a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1403   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          32       32           
  Lines       26699    26714   +15     
=======================================
+ Hits        26593    26608   +15     
  Misses         55       55           
  Partials       51       51           

Flag	Coverage Δ
unittests	99.60% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[xuri]

I made some changes based on this branch. Fix formula calculate accuracy for functions IMSECH, IMSQRT, CHIINV, CHISQ.DIST and NEGBINOM.DIST.