Add QC filtering to the WSPD variable for AMSR2 L2 GAASP#3332
Merged
djhoese merged 6 commits intopytroll:mainfrom Feb 6, 2026
Merged
Add QC filtering to the WSPD variable for AMSR2 L2 GAASP#3332djhoese merged 6 commits intopytroll:mainfrom
djhoese merged 6 commits intopytroll:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3332 +/- ##
=======================================
Coverage 96.33% 96.34%
=======================================
Files 463 463
Lines 58926 58970 +44
=======================================
+ Hits 56769 56813 +44
Misses 2157 2157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pnuu
reviewed
Feb 5, 2026
Member
pnuu
left a comment
There was a problem hiding this comment.
Example how the filtering is turned on would be nice.
Member
Author
|
🤦 of course. I'll add that when I'm back at my computer. |
Some CI runners seem to be a little more off than others
Pull Request Test Coverage Report for Build 21751520498Details
💛 - Coveralls |
Member
Author
|
Updating from the conversation on slack: Martin approved of the PR but wanted real files to be used in the tests. This has been implemented and some things refactored. Merging now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing things for Polar2Grid @kathys noticed that the AMSR2 GAASP algorithm's "OCEAN" files don't seem to have as much quality filtering for the "WSPD" variable like many of the other variables do. This PR adds an optional flag (off by default) to use "WSPD_QC" to convert bad quality pixels to NaN. From what we can tell the QC variables in the GAASP output are inconsistent so a generic solution didn't seem feasible.
AUTHORS.mdif not there already