Skip to content

Add QC filtering to the WSPD variable for AMSR2 L2 GAASP#3332

Merged
djhoese merged 6 commits intopytroll:mainfrom
djhoese:feat-amsr2-gaasp-wspd-filter
Feb 6, 2026
Merged

Add QC filtering to the WSPD variable for AMSR2 L2 GAASP#3332
djhoese merged 6 commits intopytroll:mainfrom
djhoese:feat-amsr2-gaasp-wspd-filter

Conversation

@djhoese
Copy link
Member

@djhoese djhoese commented Feb 5, 2026

While testing things for Polar2Grid @kathys noticed that the AMSR2 GAASP algorithm's "OCEAN" files don't seem to have as much quality filtering for the "WSPD" variable like many of the other variables do. This PR adds an optional flag (off by default) to use "WSPD_QC" to convert bad quality pixels to NaN. From what we can tell the QC variables in the GAASP output are inconsistent so a generic solution didn't seem feasible.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese self-assigned this Feb 5, 2026
@djhoese djhoese requested a review from mraspaud as a code owner February 5, 2026 15:40
@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Feb 5, 2026
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.34%. Comparing base (b0e6693) to head (4597879).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3332   +/-   ##
=======================================
  Coverage   96.33%   96.34%           
=======================================
  Files         463      463           
  Lines       58926    58970   +44     
=======================================
+ Hits        56769    56813   +44     
  Misses       2157     2157           
Flag Coverage Δ
behaviourtests 3.59% <0.00%> (-0.01%) ⬇️
unittests 96.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example how the filtering is turned on would be nice.

@djhoese
Copy link
Member Author

djhoese commented Feb 5, 2026

🤦 of course. I'll add that when I'm back at my computer.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 21751520498

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 96.422%

Files with Coverage Reduction New Missed Lines %
readers/amsr2_l2_gaasp.py 10 93.9%
Totals Coverage Status
Change from base Build 21639130981: 0.003%
Covered Lines: 56693
Relevant Lines: 58797

💛 - Coveralls

@djhoese
Copy link
Member Author

djhoese commented Feb 6, 2026

Updating from the conversation on slack: Martin approved of the PR but wanted real files to be used in the tests. This has been implemented and some things refactored. Merging now...

@djhoese djhoese merged commit 9cccb77 into pytroll:main Feb 6, 2026
18 checks passed
@djhoese djhoese deleted the feat-amsr2-gaasp-wspd-filter branch February 6, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:readers enhancement code enhancements, features, improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants