Add import smoke tests to PR CI (#19091)#19091
Add import smoke tests to PR CI (#19091)#19091abhinaykukkadapu wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19091
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 Cancelled Job, 7 Unrelated FailuresAs of commit dc00b11 with merge base cb94506 ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
@abhinaykukkadapu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102218906. |
This PR needs a
|
meta-codesync
Bot
changed the title
Summary: Add a PR QNN import job that validates backend module imports and statically checks internal imports for runnable Qualcomm example entrypoints. Also fix the stale `ExecutorchBackendConfig` import in the QAIHub stable diffusion example so the new check passes. Differential Revision: D102218906
abhinaykukkadapu
force-pushed
the
export-D102218906
branch
from
ea7bf8d to
4806a11
Compare
Summary: Add a PR QNN import job that validates backend module imports and statically checks internal imports for runnable Qualcomm example entrypoints. Also fix the stale `ExecutorchBackendConfig` import in the QAIHub stable diffusion example so the new check passes. Differential Revision: D102218906
abhinaykukkadapu
force-pushed
the
export-D102218906
branch
from
4806a11 to
54ed6fc
Compare
abhinaykukkadapu
requested review from
GregoryComer,
haowhsu-quic,
shewu-quic and
winskuo-quic
winskuo-quic
left a comment
winskuo-quic
left a comment
There was a problem hiding this comment.
Thanks for adding these checks to make QNN flow more reliable.
Please have a look at the comments.
| raise RuntimeError("Cannot set both compile_only and pre_gen_pte as true") | ||
|
|
||
| skip_node_id_set, skip_node_op_set = parse_skip_delegation_node(args) | ||
| skip_node_id_set, skip_node_op_set = parse_skip_delegation_args(args) |
There was a problem hiding this comment.
Thanks for the fix over here.
I actually had a PR addressing this issue. I believe this is caused by depth_anything and python api refactor PR merged around the same time.
Could you take a look at this PR and see if this fix your isue?
#19058
Thanks
There was a problem hiding this comment.
Thanks for the fix, yeah, my goal is to catch these drifts on CI. Not just specific to this file, it just happened to fail so i put up a fix in the same PR. I will rebase to your changes.
| pip install -r requirements-examples.txt | ||
|
|
||
| # Validate QNN backend Python imports resolve. | ||
| # Catches missing deps (lm_eval, openpyxl, etc.) early with a clear error. |
There was a problem hiding this comment.
I believe the comment for lm_eval should be placed on top of test_qnn_example_imports.py and not test_qnn_imports.py right? Since we only use lm_eval under example folder
There was a problem hiding this comment.
Will modify. Also made this generic so this can be used by other backends.
abhinaykukkadapu
force-pushed
the
export-D102218906
branch
from
54ed6fc to
b9d389e
Compare
Summary: Add a PR QNN import job that validates backend module imports and statically checks internal imports for runnable Qualcomm example entrypoints. This test has already pointed out some stale imports, fixing them in the safe pr. Differential Revision: D102218906
Summary: Add a PR QNN import job that validates backend module imports and statically checks internal imports for runnable Qualcomm example entrypoints. This test has already pointed out some stale imports, fixing them in the safe pr. Differential Revision: D102218906
abhinaykukkadapu
force-pushed
the
export-D102218906
branch
from
b9d389e to
ce79484
Compare
Summary: Add a PR QNN import job that validates backend module imports and statically checks internal imports for runnable Qualcomm example entrypoints. This test has already pointed out some stale imports, fixing them in the safe pr. Differential Revision: D102218906
abhinaykukkadapu
force-pushed
the
export-D102218906
branch
from
ce79484 to
dc00b11
Compare
2 participants
Summary:
Add a PR QNN import job that validates backend module imports and statically checks internal imports for runnable Qualcomm example entrypoints.
This test has already pointed out some stale imports, fixing them in the same pr.
Differential Revision: D102218906