Delete deprecated PlainLayout, PlainAQTTensorImpl and related v1 code paths#4151
Open
jerryzh168 wants to merge 12 commits intogh/jerryzh168/67/basefrom
Open
Delete deprecated PlainLayout, PlainAQTTensorImpl and related v1 code paths#4151jerryzh168 wants to merge 12 commits intogh/jerryzh168/67/basefrom
jerryzh168 wants to merge 12 commits intogh/jerryzh168/67/basefrom
Conversation
… paths - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4151
Note: Links to docs will display an error until the docs builds have been completed. ❌ 12 New FailuresAs of commit 218106c with merge base 1f90b4d ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 23, 2026
…ted v1 code paths" - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
…ted v1 code paths" - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
…ted v1 code paths" - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
…ted v1 code paths" - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
…ted v1 code paths" - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
andrewor14
approved these changes
Mar 24, 2026
Contributor
|
Technically these were only deprecated recently (as of #4074). We can still delete them now, just want to point out it hasn't been 1 release yet |
…ted v1 code paths" - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
Contributor
Author
I think it's fine since the v1 config has been deprecated for a long time |
…ted v1 code paths" - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
…ted v1 code paths" - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
…ted v1 code paths" - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
…ted v1 code paths" - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 24, 2026
… paths - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types ghstack-source-id: dbc2543 Pull Request resolved: #4151
…ted v1 code paths" - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 24, 2026
… paths - Remove PlainLayout class from dtypes/utils.py - Delete torchao/dtypes/uintx/plain_layout.py - Remove int8 weight and int8 dynamic activation dispatch from AQT dispatch table - Remove AQT embedding dispatch (used PlainAQTTensorImpl) - Change Int8WeightOnlyConfig default to version=2 (removes v1 AQT path) - Change Int8DynamicActivationInt8WeightConfig default to version=2 (removes v1 AQT path) - Remove PlainLayout from public exports - Update tests to use v2 tensor types ghstack-source-id: dbc2543 Pull Request resolved: #4151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):