Add mixed granularity tests for smooth quant#3847
Open
cyxlily wants to merge 5 commits intopytorch:mainfrom
Open
Add mixed granularity tests for smooth quant#3847cyxlily wants to merge 5 commits intopytorch:mainfrom
cyxlily wants to merge 5 commits intopytorch:mainfrom
Conversation
Signed-off-by: Cui, Lily <lily.cui@intel.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3847
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Signed-off-by: Cui, Lily <lily.cui@intel.com>
Xia-Weiwen
approved these changes
Mar 18, 2026
Xia-Weiwen
added
the
module: not user facing
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional SmoothQuant test coverage to validate behavior when activation and weight quantization granularities are configured independently (mixed granularity), split out from #3524.
Changes:
- Expand
test_smoothquant_accuracyparameterization to include mixed activation/weight granularities for int8 dynamic and int8 static configs. - Add explicit per-row/per-tensor variants for int8 dynamic configs alongside mixed-granularity cases.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "base_config", | ||
| [ | ||
| Int8DynamicActivationInt8WeightConfig(version=2), | ||
| Int8DynamicActivationInt8WeightConfig(version=2, granularity=PerRow()), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #3524
Test different activation and weight granularities for smooth quantization.