[X86] Add convert_element_type to smooth quant pattern#3784
Open
cyxlily wants to merge 15 commits intopytorch:mainfrom
Open
[X86] Add convert_element_type to smooth quant pattern#3784cyxlily wants to merge 15 commits intopytorch:mainfrom
cyxlily wants to merge 15 commits intopytorch:mainfrom
Conversation
Signed-off-by: Cui, Lily <lily.cui@intel.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3784
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the smooth quantization pattern matching to support operations that include convert_element_type nodes. The changes enable the pattern matcher to recognize and handle quantization patterns with additional type conversion operations.
Changes:
- Added
convert_aparameter toget_pattern_no_biasfunction to generate patterns with extraconvert_element_typenodes - Created new pattern variants (
pattern_no_bias_1_c1,pattern_no_bias_1_c2, etc.) to match different combinations of conversion operations - Updated validation logic to accept additional match node counts (8, 9, 12) for the new patterns
- Modified keyword argument handling to use
x_scale_dtypeand makedtypeoptional with fallback
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xia-Weiwen
changed the title
Signed-off-by: Cui, Lily <lily.cui@intel.com>
Signed-off-by: Cui, Lily <lily.cui@intel.com>
Xia-Weiwen
reviewed
Feb 4, 2026
Collaborator
Xia-Weiwen
left a comment
Xia-Weiwen
left a comment
There was a problem hiding this comment.
Thanks for the PR. Please also add a UT.
Signed-off-by: Cui, Lily <lily.cui@intel.com>
Signed-off-by: Cui, Lily <lily.cui@intel.com>
Signed-off-by: Cui, Lily <lily.cui@intel.com>
Signed-off-by: Cui, Lily <lily.cui@intel.com>
jerryzh168
reviewed
Feb 13, 2026
Signed-off-by: Cui, Lily <lily.cui@intel.com>
Moved to the other pr. Signed-off-by: Cui, Lily <lily.cui@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1863
to
1871
| def _validate_pattern(match: Match): | ||
| if len(match.nodes) not in [4, 5, 6, 7, 10]: | ||
| # Valid node counts correspond to different pattern variations: | ||
| # 4: pattern1_with_no_outer_or_act_reshape (int_mm + convert + mul + mul) | ||
| # 6: pattern_no_bias_1 (reshape + int_mm + convert + mul + mul + reshape) | ||
| # 7: pattern_with_bias_1 (pattern_no_bias_1 + add) | ||
| # 8: pattern_no_bias_1_with_output_convert (pattern_no_bias_1 with dot scaled + output convert) | ||
| # 9: pattern_with_bias_1_with_output_convert (pattern_with_bias_1 with dot scaled + output convert) | ||
| if len(match.nodes) not in [4, 6, 7, 8, 9]: | ||
| return False |
Comment on lines
1788
to
1789
| # When torch.compile'ing with dynamic=True, the expand node and the two tailing reshape nodes exist | ||
| # When torch.compile'ing with dynamic=False, they don't exist |
Comment on lines
+1790
to
+1791
| def get_pattern_no_bias(reshape_a: bool = True, convert_a: bool = False): | ||
| int_mm_pattern = CallFunction( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.