Make Rule's unasync functions public for overwriting#84
Make Rule's unasync functions public for overwriting#84pquentin merged 3 commits intopython-trio:masterfrom
Conversation
5d08d89 to
aff9c84
Compare
pquentin
left a comment
There was a problem hiding this comment.
I'm not sure I want to encourage Rule inheritance, since we could break it later, especially since there are no tests. But happy to merge if it helps you.
|
Hey @robsdedude, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂 If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:
If you want to read more, here's the relevant section in our contributing guide. Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you. If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out! |
Thanks, I really appreciate the pragmatic approach. If you have suggestions on a more solid design/approach, I'm happy work on it. Maybe configurable callbacks/hook or such? |
I propose to make the
unasyncfunctions ofRulepublic so that customRuleimplementations can more easily inherit fromRuleand change the exact replacement mechanisms.Here are my use-cases that this would enable without having to rely on internal APIs:
unasync_string):ref:`async-thingamajig`to:ref:`thingamajig`.