Conversation
|
Can I provide arguments to save the function? Like compression mode, flags and etc? |
|
Like |
|
Yes, that's just what I needed, thanks! |
|
@radarhere Do I need to encode the image row-by-row or i can go like 4 rows at once because Bcn works in blocks of 4 by 4 pixels? |
No, you don't have to. A while ago, I attempted to implement DXT1 encoding. You might find that helpful - radarhere@363fab4 |
|
I see, your attempt is quite close to what I wrote, but I used a different way to get 2 main colors for the block. Can I reuse some of your code from 363fab4? |
|
Feel free |
|
@radarhere Can you please review my bcn encoder? |
|
Slightly confused - this PR is still a draft, but you'd like a review? Also, your lint problems could be resolved by just using the black formatting - REDxEYE#2. Is there a particular part of the styling that you dislike? |
I'm asking for a encoder code review, pr itself not even close to be ready :) |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
|
All of the test images you've included are able to be distributed as part of Pillow under our license, yes? |
|
Yes, these are test images i created myself, so they are non-copyrighted |
|
I've created REDxEYE#11 with some suggestions. |
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
05363a2 to
bb81269
Compare
This pull request adds initial support for VTF image format
Changes proposed in this pull request: