fix: Use importlib for 3.12+ compatibility. #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully solves this issue: pyranges#10 I haven't tested retro-compatibility for older Python versions, though.
Collaborator
|
You are very kind to do this. I’ll look at it tomorrow morning. |
|
I would also appreciate it if this fix was merged :) |
Collaborator
|
Sorry! I'll fix it today. I'm so busy on the new and improved pyranges which is ready now: https://github.com/pyranges/pyranges_1.x |
Collaborator
|
Thanks to you all for making the PR and nagging me. |
Collaborator
|
I still need to build the package and upload wheels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully solves this issue:
#10
I have tested Python 3.13.2 and 3.8.18 as follows:
In both cases it is able to print something ("0.0.40").