Merged
Conversation
Contributor
|
Should we update the version bounds for preliz? Otherwise LGTM! |
Member
Author
|
Why is the preliz version implicated? Let's a a round of version pin updates next, a lot of stuff looks very out of date. |
Contributor
|
Oh, because presumably this fix wasn't needed on older versions of preliz. So unless we are sure we still support all versions, why not tighten the bound? |
Member
Author
|
The core issue is a warning because preliz is using depreciated |
Member
Author
|
I opened a PR in preliz to fix the warning: arviz-devs/preliz#710 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncovered in #654
There are some upstream changes in pymc/pytensor/preliz (unrelated to v3/v6) that are causing failing tests here. Nothing exciting.