Draft
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Author
|
Pushed latest progress: working with Filter, not yet with Smoother |
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
conda-envs/environment-test.yml:20
- [nitpick] The pip dependency list appears to have a potentially misformatted entry ('- -e .'); please verify the correct YAML structure to ensure dependencies are installed as intended.
- -e .
Comment on lines
+78
to
+85
| assert 0 | ||
| # outputs = filter_func(*inputs) | ||
|
|
||
| for output_idx, name in enumerate(output_names): | ||
| expected_output = get_expected_shape(name, p, m, r, n) | ||
| assert ( | ||
| outputs[output_idx].shape == expected_output | ||
| ), f"Shape of {name} does not match expected" | ||
| expected_shape = get_expected_shape(name, p, m, r, n, batch_size) | ||
| # assert outputs[output_idx].shape == expected_shape, ( | ||
| # f"Shape of {name} does not match expected" | ||
| # ) |
There was a problem hiding this comment.
A hard-coded 'assert 0' is present in the test_output_shapes_one_state_one_observed function, which forces the test to fail. Please remove this debugging placeholder to allow the test to run normally.
| covs = pt.moveaxis(covs, -3, 0) | ||
|
|
||
| mus_, covs_ = mus.type(), covs.type() | ||
| print(f"mus_.type.shape: {mus_.type.shape}, covs_.type.shape: {covs_.type.shape}") |
There was a problem hiding this comment.
Debug print statements remain in the rv_op function; consider removing them before merging to clean up output in production.
Suggested change
| print(f"mus_.type.shape: {mus_.type.shape}, covs_.type.shape: {covs_.type.shape}") | |
| # Debugging information removed or replaced with logging if necessary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add batch dimension feature to Kalman filters, to enable fitting multiple time series at the same time