Skip to content
This repository was archived by the owner on Apr 11, 2026. It is now read-only.

experiment with "ref" form of extra#1786

Draft
davidhewitt wants to merge 2 commits intopydantic:mainfrom
davidhewitt:dh/owned-extra
Draft

experiment with "ref" form of extra#1786
davidhewitt wants to merge 2 commits intopydantic:mainfrom
davidhewitt:dh/owned-extra

Conversation

@davidhewitt
Copy link
Copy Markdown
Collaborator

Change Summary

Experiment whether avoiding taking ownership of extra can aid performance. Not ready, pushing for codspeed feedback.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/serializers/type_serializers/function.rs 0.00% 60 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Sep 15, 2025

CodSpeed Performance Report

Merging #1786 will not alter performance

Comparing davidhewitt:dh/owned-extra (0fe0b40) with main (1cd5ee3)

Summary

✅ 161 untouched

@davidhewitt
Copy link
Copy Markdown
Collaborator Author

I realise there is no benchmark for this serialization pathway, will add one.

@davidhewitt
Copy link
Copy Markdown
Collaborator Author

The signal is slightly too small to show here, this is a ~5% improvement on the wrap serializer performance according to codspeed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant