This repository was archived by the owner on Apr 11, 2026. It is now read-only.
Merged
Conversation
CodSpeed Performance ReportMerging #1559 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
==========================================
- Coverage 90.21% 89.63% -0.59%
==========================================
Files 106 112 +6
Lines 16339 17889 +1550
Branches 36 40 +4
==========================================
+ Hits 14740 16034 +1294
- Misses 1592 1835 +243
- Partials 7 20 +13
... and 57 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Author
|
please review |
davidhewitt
approved these changes
Dec 3, 2024
Collaborator
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks for following up 👍
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
Original-commit-hash: be87e05
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 22, 2025
Original-commit-link: pydantic/pydantic-core@be87e05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Following David's comment: #1551 (review)
Replacing the explicitly imported python
UserWarningwithPyUserWarningfrom pyo3. This might slightly improve performance in this case, depending on how pyo3 actually raises warnings. In the worst case it should be the same as the current implementation, so there's no harm doing this.Related issue number
None.
Checklist
pydantic-core(except for expected changes)Selected Reviewer: @sydney-runkle