This repository was archived by the owner on Apr 11, 2026. It is now read-only.
Draft
Conversation
Contributor
sydney-runkle
left a comment
sydney-runkle
left a comment
There was a problem hiding this comment.
Just some general ideas - I think we should try to move forward here!
| type Error = PyErr; | ||
| fn try_from(value: Bound<'_, PyDict>) -> Result<Self, Self::Error> { | ||
| Ok(CoreConfig { | ||
| title: value.get_item("title")?.map(|v| v.extract()).transpose()?, |
Contributor
There was a problem hiding this comment.
Maybe we use a helper function to reduce the repetition with the ?.map(|v| v.extract()).transpose()??
Contributor
There was a problem hiding this comment.
Maybe a helper function and a macro would be a good combo here
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub enum CacheStrings { |
Contributor
There was a problem hiding this comment.
Nice to see all of these moved to an intuitive place
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial stab at #1337.
Lots more work needed