[feat] change privacy-policy class style to tailwind inlines#512
Open
[feat] change privacy-policy class style to tailwind inlines#512
Conversation
✅ Deploy Preview for ephemeral-sable-89c7e0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mhsiungw
changed the title
SivanYeh
reviewed
Apr 16, 2024
Collaborator
SivanYeh
left a comment
SivanYeh
left a comment
There was a problem hiding this comment.
Awesome works! And it fits well at my local.
However "important" this part is new to me. Let me see if someone more experienced than me can check.
baby230211
reviewed
Apr 17, 2024
| mode: 'jit', | ||
| purge: [], | ||
| darkMode: false, // or 'media' or 'class' | ||
| important: true, |
Collaborator
There was a problem hiding this comment.
Due to this config may affected all site of css, we cannot guarantee that all page is correct.
I don't think it's a good idea to add important in every tailwind generated css.
If we're going to migrate scss to tailwind, then maybe we should have a migration plan or review the new code and refactor to tailwind in every new PRs of new code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
important: trueintailwind.config.jsto make switching to tailwind css convention easier(see Define Style coding convention #396)
Related Issue
#499
Additional context
This PR is a prove of concept as discussed in #511.