Open
Conversation
… states being out of date after initializing the pair_generator the first time.
Member
|
Thanks for this @darkvertex. I can't spot what's gone wrong from a quick glance, but if it helps you're welcome to remove the iterator altogether, and with it the ability to "pause" which I think is the thing making the most fuss. It has never really worked out that well, and likely doesn't provide much value either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not really working quite right yet, but I'm giving it a try. Advice, corrections, tips all welcome.
This is my testing scenario which generates
potato_0throughpotato_3and only the last one is activated:Previous to this PR, if you untick
potato_3and tick any of the others, potato_3 will get a green outline, meaning it processed, despite being deactivated.With the code as it stands at the moment, if I uncheck
potato_3, it does not get evaluated, but neither does the others. It seems I made the whole FakeValidator skip instead of the individual instance. I must've done something wrong somewhere.