Skip to content

Multiple jobs per instance + job for context - #39

Open
asztalosdani wants to merge 2 commits into
pyblish:masterfrom
asztalosdani:master
Open

Multiple jobs per instance + job for context#39
asztalosdani wants to merge 2 commits into
pyblish:masterfrom
asztalosdani:master

Conversation

@asztalosdani

Copy link
Copy Markdown

Fixes #20 #38

@asztalosdani

Copy link
Copy Markdown
Author

Continuing the conversation from #38

Since you probably would like to use separate Deadline plugins, in your case Maya ass export and Arnold standalone render, you would want to configure the plugin data as well.
How about having a instance.data["deadlineData"]["submissions"] which will be a list of dictionaries containing job and plugin entries?

Currently the instance.data["deadlineData"] is the list of dictionaries containing job and plugin entries.
The instance.data["deadlineData"]["submissions"] would break backward compatibility. Even if it's ok, I'm not convinced, because this way, the ["deadlineData"] has always exactly one, ["submissions"] entry.

@mottosso

Copy link
Copy Markdown
Member

Nice one! @tokejepsen is the man behind the curtain on this one, will let him handle feedback and merging.

@tokejepsen

Copy link
Copy Markdown
Member

The instance.data["deadlineData"]["submissions"] would break backward compatibility.

I don't quite understand why that would break backwards compatibility. instance.data["deadlineData"] is a dictionary, so adding another entry would be backwards compatible. Maybe there is something I'm not understanding?

We could also just have a completely new data member for submissions, like instance.data["deadlineSubmissions"] and context.data["deadlineSubmissions"]?
This maintained backwards compatibility and maybe be clearer for new people coming in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants