You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since you probably would like to use separate Deadline plugins, in your case Maya ass export and Arnold standalone render, you would want to configure the plugin data as well.
How about having a instance.data["deadlineData"]["submissions"] which will be a list of dictionaries containing job and plugin entries?
Currently the instance.data["deadlineData"] is the list of dictionaries containing job and plugin entries.
The instance.data["deadlineData"]["submissions"] would break backward compatibility. Even if it's ok, I'm not convinced, because this way, the ["deadlineData"] has always exactly one, ["submissions"] entry.
The instance.data["deadlineData"]["submissions"] would break backward compatibility.
I don't quite understand why that would break backwards compatibility. instance.data["deadlineData"] is a dictionary, so adding another entry would be backwards compatible. Maybe there is something I'm not understanding?
We could also just have a completely new data member for submissions, like instance.data["deadlineSubmissions"] and context.data["deadlineSubmissions"]?
This maintained backwards compatibility and maybe be clearer for new people coming in?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20 #38