add angle brackets to docstring type stack parsing#311
Open
htruscott wants to merge 1 commit into
Open
Conversation
Signed-off-by: htruscott <harrison@harriscott.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds "<": ">" to the stack-parsing logic in
ExtractSignaturesFromPybind11Docstrings._split_args_strandExtractSignaturesFromPybind11Docstrings._split_str, allowing for C++ templated classes with multiple type arguments to be parsed properly.Previously, due to the commas, each type in a template is parsed as a separate argument, leading to extra parameters in stubs with nonsensical (often duplicate) names. For example
void f(std::pair<std::pair<std::int,std::string>, std::pair<std::int,std::string>> arg0)would get parsed asarg0: "std::pair<std::pair<std::int", std: ":int,std::string>", std: ":pair<std::int", std: ":string>>". The nonsensical type strings of course get converted to "...", but the extra duplicate names remain making the stubs unparseable. Adding brackets to the stack correctly activates the logic to only separate by commas if there are no enclosing brackets/parentheses/etc.