Added temporal error analysis#89
Open
audribean wants to merge 4 commits into
Open
Conversation
MatiasDiBernardo
suggested changes
Jul 3, 2026
MatiasDiBernardo
left a comment
MatiasDiBernardo
left a comment
There was a problem hiding this comment.
Two main points to address:
- Some comments on
category_error_analysis.pyabout not being generic. Also If you can add an example of use (as you have for the other file it will help me to test it) - Decouple calculation and plotting. I think it should be cleaner (from code and from use experience perspective), but let me know what do you think, as it was written in conjunction maybe if you try to decouple it now it breaks a lot of things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.