Skip to content

Factor out CODEC and fix policy risk implementation#336

Open
1andrin wants to merge 2 commits intopy-why:mainfrom
1andrin:edit_codec
Open

Factor out CODEC and fix policy risk implementation#336
1andrin wants to merge 2 commits intopy-why:mainfrom
1andrin:edit_codec

Conversation

@1andrin
Copy link
Contributor

@1andrin 1andrin commented Jan 21, 2025

Problem

  • CODEC is using up too much space in scoring.py, impairing readability.
  • The current policy risk implementation is incorrect.

Proposed changes

  • Factor out CODEC into a separate file.
  • Fix policy risk implementation.

Types of changes

What types of changes does your code introduce to causaltune?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Signed-off-by: 1andrin <115493865+1andrin@users.noreply.github.com>
Signed-off-by: 1andrin <115493865+1andrin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant