ENH: Preserve links in added pages also when links come from merged-in pages#3400
Open
larsga wants to merge 1 commit intopy-pdf:mainfrom
Open
ENH: Preserve links in added pages also when links come from merged-in pages#3400larsga wants to merge 1 commit intopy-pdf:mainfrom
larsga wants to merge 1 commit intopy-pdf:mainfrom
Conversation
larsga
force-pushed
the
issue-3290-part-2
branch
from
90563bc to
016e81f
Compare
larsga
changed the title
larsga
force-pushed
the
issue-3290-part-2
branch
4 times, most recently
from
0d55180 to
75cb5ad
Compare
larsga
force-pushed
the
issue-3290-part-2
branch
from
75cb5ad to
956e3fd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3400 +/- ##
==========================================
+ Coverage 96.91% 96.95% +0.04%
==========================================
Files 55 55
Lines 9324 9350 +26
Branches 1706 1715 +9
==========================================
+ Hits 9036 9065 +29
+ Misses 172 170 -2
+ Partials 116 115 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| [tool.pytest.ini_options] | ||
| addopts = "--disable-socket" | ||
| #addopts = "--disable-socket" |
Collaborator
This is an unexpected side effect of these changes and as we know that it decreases performance, I cannot merge this PR safely without addressing the speed issues - ideally as a separate PR. |
stefan6419846
added
needs-discussion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last part of the implementation of issue 3290.
It causes the tests to be slow because
named_destinationsis not cached, but I'm leaving that as a separate task.