Allow for lvs to be created on specific pv#335
Open
elbandi wants to merge 4 commits intopuppetlabs:mainfrom
Open
Allow for lvs to be created on specific pv#335elbandi wants to merge 4 commits intopuppetlabs:mainfrom
elbandi wants to merge 4 commits intopuppetlabs:mainfrom
Conversation
Author
|
Sould i squash the commits? |
malikparvez
reviewed
Jul 11, 2024
Member
|
Hey @elbandi could you please resolve the conflicts and write the specs for the change... |
15cbbc0 to
9f9fe8e
Compare
Author
Resolved, and added a spec (I didn't know what to add... ) |
e9a210e to
a16b51f
Compare
a16b51f to
1e9be33
Compare
1e9be33 to
d0c00bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change allows the use of
physical_volumeas argument tological_volumeso that the new lv will be created on a specific physical volume even if the volume group consists of several physical volumes.Sample
Related Issues
This is an updated and tweaked version of #212.