blkid returning 2 is not an error in this case#258
Open
cbudziszewski wants to merge 2 commits intopuppetlabs:mainfrom
Open
blkid returning 2 is not an error in this case#258cbudziszewski wants to merge 2 commits intopuppetlabs:mainfrom
cbudziszewski wants to merge 2 commits intopuppetlabs:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blkid returns error code 2 if a path does not exist, which causes puppet to bail and not remove the lv.
A similar issue was already fixed for resizing (https://github.com/puppetlabs/puppetlabs-lvm/pull/188/files).
It may be better to wrap the blkid call somehow, since it is used multiple times in the code and has more than one valid exit code.