fix: allow plus signs in ppa#1222
Open
moritz-makandra wants to merge 1 commit intopuppetlabs:mainfrom
Open
Conversation
moritz-makandra
requested review from
a team,
bastelfreak and
smortex
as code owners
|
|
|
I guess #583 got lost somewhere. |
smortex
reviewed
Feb 11, 2025
Collaborator
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
Some extra escaping (and if this escaping is in fact required, this looks inconsistent)
From Launchpad:
> At least one lowercase letter or number, followed by letters, numbers,
> dots, hyphens or pluses. Keep this name short; it is used in URLs.
moritz-makandra
force-pushed
the
main
branch
from
cb2da41 to
f6b9da4
Compare
smortex
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PPA names can have plus signs
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)