Skip to content

[DYNAREC] Restored sep entries hidden dynablock reference#3822

Merged
ptitSeb merged 2 commits intoptitSeb:mainfrom
ksco:fix-sep-dynacache
May 6, 2026
Merged

[DYNAREC] Restored sep entries hidden dynablock reference#3822
ptitSeb merged 2 commits intoptitSeb:mainfrom
ksco:fix-sep-dynacache

Conversation

@ksco
Copy link
Copy Markdown
Collaborator

@ksco ksco commented May 6, 2026

This fixes Linux Steam SIGBUS issues with DynaCache.

@ptitSeb
Copy link
Copy Markdown
Owner

ptitSeb commented May 6, 2026

Looks good, but I don't see where the new db->sep_nolink is set/unset in the PR?

@ksco
Copy link
Copy Markdown
Collaborator Author

ksco commented May 6, 2026

Looks good, but I don't see where the new db->sep_nolink is set/unset in the PR?

Oops, I think I messed up this patch when trying to do a rebase with conflicts...

@ksco
Copy link
Copy Markdown
Collaborator Author

ksco commented May 6, 2026

Okay I added that line back.

Comment thread src/custommem.c Outdated
Comment thread src/libtools/signals.c Outdated
Comment thread src/dynarec/dynablock.c Outdated
@ptitSeb
Copy link
Copy Markdown
Owner

ptitSeb commented May 6, 2026

Are you sure just the handling in custommem.c/MmaplistAddBlock is not enough (even without db->sep_nolink)?

This fixes Linux Steam SIGBUS issues with DynaCache.
@ksco ksco force-pushed the fix-sep-dynacache branch from 5348dc9 to c5a8a58 Compare May 6, 2026 09:24
@ksco ksco changed the title [DYNAREC] Kept cached SEP entries on jmpnext [DYNAREC] Restored sep entries hidden dynablock reference May 6, 2026
@ksco
Copy link
Copy Markdown
Collaborator Author

ksco commented May 6, 2026

Thanks for the review. Restoring hidden dynablock* headers for SEP fixes Steam issue already, actually. I might have made some mistakes when testing. SEP offsets are perfectly safe to use! I have force-pushed and updated the PR title.

Comment thread src/custommem.c Outdated
@ptitSeb
Copy link
Copy Markdown
Owner

ptitSeb commented May 6, 2026

Thanks for the review. Restoring hidden dynablock* headers for SEP fixes Steam issue already, actually. I might have made some mistakes when testing. SEP offsets are perfectly safe to use! I have force-pushed and updated the PR title.

Yeah, the SEP+DynaCache has not be tested at all. My fault, I should have done a small test campaign, so expect some more issue there :'(

@ptitSeb
Copy link
Copy Markdown
Owner

ptitSeb commented May 6, 2026

Looks good now, thanks! And sorry for the chaotic review...

@ptitSeb ptitSeb merged commit b619090 into ptitSeb:main May 6, 2026
28 checks passed
@ksco ksco deleted the fix-sep-dynacache branch May 7, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants