[ARM64_DYNAREC] Fix NaN detection operand typo#3820
Merged
ptitSeb merged 1 commit intoptitSeb:mainfrom May 4, 2026
Merged
Conversation
The fastnan=0 path of VSQRTSS compared `v1` against itself for NaN
detection, but `v1` is never assigned in this case where the input is
loaded into `d0` by GETEXSS.
Before fix:
sqrt(4.0) 0x40000000 2
sqrt(-1.0) 0xffc00000 -NaN
sqrt(+QNaN) 0xffc00000 -NaN <-- expected 0x7fc00000 (+NaN)
sqrt(-QNaN) 0xffc00000 -NaN
After fix:
sqrt(4.0) 0x40000000 2
sqrt(-1.0) 0xffc00000 -NaN
sqrt(+QNaN) 0x7fc00000 +NaN
sqrt(-QNaN) 0xffc00000 -NaN
Owner
|
Indeed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fastnan=0 path of VSQRTSS compared
v1against itself for NaN detection, butv1is never assigned in this case where the input is loaded intod0by GETEXSS.Before fix:
After fix:
Thanks !